Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

    Apple Removes Shadow DOM from Safari (webkit.org)
It looks like it was already removed, this is just some stuff they missed? Purge remaining ENABLE(SHADOW_DOM) cruft ... Showing 66 changed files with 40 additions and 399 deletions. [1]

[1] https://github.com/WebKit/webkit/commit/0e1e0ebf18aaac177366...



Oh, you mean these are just the remaining 8.8 million lines of shadow DOM code?


No? I don't understand how your question makes sense in relation to the GP comment. You can see the entirety of the diff here: https://bugs.webkit.org/attachment.cgi?id=224240&action=diff

I believe most of the shadow DOM stuff was removed almost a year ago after the Blink fork, because the maintainers of the code were leaving with Blink. eg

> Is anyone intending to maintain the feature on trunk? If not, we should simply get rid of code behind this build flag for now; keeping unmaintained code that doesn't even compile isn't healthy for the project of our size.[1]

It looks like this was just some last remaining code behind a leftover build flag.

[1] https://lists.webkit.org/pipermail/webkit-dev/2013-May/02489...


You're correct, by and large shadow dom "support" (unmaintained and behind a flag) was removed back in may: http://trac.webkit.org/changeset/150070 http://trac.webkit.org/changeset/150430 http://trac.webkit.org/changeset/150464


That's the joke, I assume - ALL of WebKit is less than 8.8 million lines.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: